Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly add package data directories to distribution #80

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

akosthekiss
Copy link
Collaborator

Python recognizes package data directories as importable packages. However, as they are absent from setuptools' packages configuration, this causes warnings that they would be ignored. The recommended approach is to treat data as namespace package using the find_namespace: discovery mechanism.

The affected data directories / packages:

  • fuzzinator.ui.tui.resources
  • fuzzinator.ui.wui.resources.static
  • fuzzinator.ui.wui.resources.static.assets
  • fuzzinator.ui.wui.resources.static.images
  • fuzzinator.ui.wui.resources.static.scripts
  • fuzzinator.ui.wui.resources.static.styles
  • fuzzinator.ui.wui.resources.templates
  • fuzzinator.ui.wui.resources.templates.report

Python recognizes package data directories as importable packages.
However, as they are absent from setuptools' `packages`
configuration, this causes warnings that they would be ignored. The
recommended approach is to treat data as namespace package using
the `find_namespace:` discovery mechanism.

The affected data directories / packages:
- fuzzinator.ui.tui.resources
- fuzzinator.ui.wui.resources.static
- fuzzinator.ui.wui.resources.static.assets
- fuzzinator.ui.wui.resources.static.images
- fuzzinator.ui.wui.resources.static.scripts
- fuzzinator.ui.wui.resources.static.styles
- fuzzinator.ui.wui.resources.templates
- fuzzinator.ui.wui.resources.templates.report
Copy link
Owner

@renatahodovan renatahodovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@renatahodovan renatahodovan merged commit 8815fa4 into renatahodovan:master Dec 17, 2024
24 checks passed
@akosthekiss akosthekiss deleted the find-namespace branch December 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants