feat: make O'Mesh on Impeller great again #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the instability on Impeller seems to be specifically when we use
.drawVertices
with aFragmentShader
, I figured if we pre-render all gradient patches in a temporary canvas, record it into aui.Image
instance and then use anImageShader
instead of a FragmentShader, impeller won't panic.Of course, this has some performance overhead, but since #10, O'Mesh's performance has been so good, that it's unnoticeable in almost all hardware I tested (mac m1 and iPad a14).
But to be safe, I added two flags:
Breaking
The
impellerCompatibilityMode
option available on the widgets are not necessary anymore.(Required) Link to the issue
#9