Update types and jsdocs #2232
Open
Update types and jsdocs #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nodemon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ravin00
reviewed
Oct 26, 2024
| event: 'config:update', | ||
| listener: (e?: NodemonEventConfig) => void | ||
| ): Nodemon; | ||
| on(event: 'exit', listener: (e?: number) => void): Nodemon; |
There was a problem hiding this comment.
Why the NodemonEventExit is changed to number
There was a problem hiding this comment.
Check line 100, export type NodemonEventExit = number;. It was pretty useless to define this type imho.
remy
added a commit
that referenced
this pull request
Dec 13, 2024
Created by @zAlweNy26 PR: #2232 Modified commit to allow for squash and conventional commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2231
I hope I haven't missed (or messed up) anything :)
I didn't understand why there are execOptions both at first level of the settings object and also nested inside
execOptions, or did I understand wrong?