Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@remotion/lambda: Faster renders when using warm starts #2991

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

JonnyBurger
Copy link
Member

@JonnyBurger JonnyBurger commented Oct 9, 2023

  • We don't call process.exit(0) anymore after a render, since the event loop leaks have been cleaned up.
  • When possible, we re-use opened Chrome instances, and unref them so the Lambda shuts down correctly
  • When the configuration changes (e.g. different gl value), we restart the browser

Finally solved all the tradeoffs!

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 4:07pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 4:07pm

@JonnyBurger JonnyBurger changed the title @remotion/lambda: Don't call process.exit(0) to keep Lambdas warm @remotion/lambda: Faster renders when using warm starts Oct 9, 2023
@JonnyBurger JonnyBurger enabled auto-merge October 9, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant