Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): prevent rebuilds from hanging #6295

Merged
merged 2 commits into from
May 3, 2023
Merged

fix(dev): prevent rebuilds from hanging #6295

merged 2 commits into from
May 3, 2023

Commits on May 3, 2023

  1. fix(dev): prevent rebuilds from hanging 

    by canceling the previous build when a new rebuild is kicked off
    @pcattori
    pcattori committed May 3, 2023
    Configuration menu
    Copy the full SHA
    52cd1e4 View commit details
    Browse the repository at this point in the history

  2. fix(dev): do not log cancelation "errors" 

    esbuild cancels builds by throwing cancelation errors,
and we copy the same approach for manually canceling builds

cancelations need to be thrown to stop execution, but they are not
in-themselves errors. so they should not be logged as errors.
    @pcattori
    pcattori committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8cad4ee View commit details
    Browse the repository at this point in the history