Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(remix-server-runtime): remove react & react-dom from peerDependencies #4801

Merged
merged 1 commit into from
Jan 23, 2023
Merged

refactor(remix-server-runtime): remove react & react-dom from peerDependencies #4801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-bobcats-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/server-runtime": minor
---

remove `react` & `react-dom` from `peerDependencies`
9 changes: 2 additions & 7 deletions packages/remix-server-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,15 @@
"dependencies": {
"@remix-run/router": "1.3.0",
"@types/cookie": "^0.4.0",
"@types/react": "^18.0.15",
MichaelDeBoey marked this conversation as resolved.
Show resolved Hide resolved
"@web3-storage/multipart-parser": "^1.0.0",
"cookie": "^0.4.1",
"set-cookie-parser": "^2.4.8",
"source-map": "^0.7.3"
},
"devDependencies": {
"@remix-run/web-file": "^3.0.2",
"@types/set-cookie-parser": "^2.4.1",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"peerDependencies": {
"react": ">=16.8",
"react-dom": ">=16.8"
"@types/set-cookie-parser": "^2.4.1"
},
"engines": {
"node": ">=14"
Expand Down
4 changes: 2 additions & 2 deletions packages/remix-server-runtime/routeModules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ComponentType } from "react";
import type { Location, Params } from "@remix-run/router";
import type { ComponentType } from "react";

import type { AppLoadContext, AppData } from "./data";
import type { LinkDescriptor } from "./links";
Expand Down Expand Up @@ -37,7 +37,7 @@ export interface ActionFunction {
/**
* A React component that is rendered when the server throws a Response.
*/
export type CatchBoundaryComponent = ComponentType<{}>;
export type CatchBoundaryComponent = ComponentType;

/**
* A React component that is rendered when there is an error on a route.
Expand Down