Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev): allow importing .csv files #3920

Merged
merged 7 commits into from
Feb 9, 2023
Merged

feat(remix-dev): allow importing .csv files #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77c88d4
feat: 🎸 add csv in modules.ts
kayac-chang Sep 3, 2022
924fd15
feat: 🎸 support import csv file
kayac-chang Aug 4, 2022
7b80a5f
Create wise-masks-sniff.md
kayac-chang Aug 4, 2022
bdeb553
Update wise-masks-sniff.md
kayac-chang Sep 8, 2022
0d85938
Merge branch 'dev' into feat/support-import-csv-file
chaance Feb 9, 2023
792212c
Update .changeset/wise-masks-sniff.md
chaance Feb 9, 2023
ede5ced
Update .changeset/wise-masks-sniff.md
chaance Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/wise-masks-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"remix": patch
kayac-chang marked this conversation as resolved.
Show resolved Hide resolved
"@remix-run/dev": patch
kayac-chang marked this conversation as resolved.
Show resolved Hide resolved
---

Add file loader for importing `.csv` files
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,4 @@
- zainfathoni
- zayenz
- zhe
- kayac-chang
1 change: 1 addition & 0 deletions packages/remix-dev/compiler/loaders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export const loaders: { [ext: string]: esbuild.Loader } = {
".aac": "file",
".avif": "file",
".css": "file",
".csv": "file",
MichaelDeBoey marked this conversation as resolved.
Show resolved Hide resolved
".eot": "file",
".fbx": "file",
".flac": "file",
Expand Down
4 changes: 4 additions & 0 deletions packages/remix-dev/modules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ declare module "*.css" {
let asset: string;
export default asset;
}
declare module "*.csv" {
let asset: string;
export default asset;
}
declare module "*.eot" {
let asset: string;
export default asset;
Expand Down