Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): Create magicExports in Rollup build #3543

Merged
merged 13 commits into from
Jun 22, 2022

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Jun 22, 2022

This PR removes all magicExports modules from the source code and emits the files via Rollup instead. This eliminates any issues with TS or Node module resolution that will occur from copying the build output into a dist directory alongside the package source.

This will unblock #3540 which in turn will unblock the work needed to implement Changesets.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
rollup.config.js Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
@brophdawg11
Copy link
Contributor

The only thing I notice on a quick diff of a dev build/ versus here is these 2 lines are missing at the top of the generated files in this branch. We don't need use strict - but unsure if the __esModule is relevant for anything in the bundle landscape or just rollup cruft though

'use strict';

Object.defineProperty(exports, '__esModule', { value: true });

Co-authored-by: Michaël De Boey <[email protected]>
rollup.config.js Show resolved Hide resolved
rollup.config.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants