Skip to content

fix(examples): use post action in firebase-auth-firestore example #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 2 commits into from
Jun 7, 2022
Merged

fix(examples): use post action in firebase-auth-firestore example #3358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88207b9
fix(examples/firebase-auth-firestore): delete is not a valid form method
penx Jun 1, 2022
68c1969
Update examples/firebase-auth-firestore/app/routes/index.tsx
penx Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions examples/firebase-auth-firestore/app/routes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,21 @@ export type ActionData = {
export const action: ActionFunction = async ({ request }) => {
const { uid } = await requireAuth(request);
const form = await request.formData();
if (request.method === "POST") {
const action = form.get("action");
if (action === "create") {
const title = form.get("title");
if (typeof title !== "string")
if (typeof title !== "string" || title.length === 0) {
return json<ActionData>({ error: "title is required" }, { status: 400 });
}

await addTodo(uid, title);
return redirect("/");
}
if (request.method === "DELETE") {
if (action === "delete") {
const id = form.get("id");
if (typeof id !== "string")
if (typeof id !== "string") {
return json<ActionData>({ error: "id is required" }, { status: 400 });
}
await removeTodo(uid, id);
return redirect("/");
}
Expand All @@ -56,10 +59,12 @@ const TodoComponent: React.FC<{ id: string; title: string }> = (props) => {
const fetcher = useFetcher();
return (
<li>
<fetcher.Form method="delete">
<fetcher.Form method="post">
<input type="hidden" name="id" value={props.id} />
<span>{props.title}</span>
<button type="submit">Delete</button>
<button type="submit" name="action" value="delete">
Delete
</button>
</fetcher.Form>
</li>
);
Expand All @@ -82,7 +87,9 @@ export default function Index() {
<Form method="post">
<h2>Create new Todo:</h2>
<input ref={ref} name="title" type="text" placeholder="Get Milk" />
<button type="submit">Create</button>
<button type="submit" name="action" value="create">
Create
</button>
</Form>
<ul>
{data.todos.map((todo) => (
Expand Down