Fix Firebase example and throw meaningful errors#3351
Closed
penx wants to merge 1 commit intoremix-run:mainfrom
Closed
Fix Firebase example and throw meaningful errors#3351penx wants to merge 1 commit intoremix-run:mainfrom
penx wants to merge 1 commit intoremix-run:mainfrom
Conversation
Apply fixes as per comment by @mocon at remix-run#1811 (comment) Also: - throw meaningul errors when environment variables are missing or can't be parsed. - check for existence of environment variable rather than cast to string
Contributor
Author
|
closing as should be against dev branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply fixes as per comment by @mocon at #1811 (comment)
Also:
Closes: issue reported in comment #1811 (comment)
Testing Strategy: