Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add and update node adapter tests #241

Merged
merged 35 commits into from
Aug 18, 2021
Merged

feat: add and update node adapter tests #241

merged 35 commits into from
Aug 18, 2021

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Aug 10, 2021 •
edited
Loading

closes #231
closes #159
closes REM-177
closes REM-179

@mcansh
feat(express): add support for multiple 'Set-Cookie' and other multi …
4e938cd 
…headers

x-ref #231

Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(express): add tests for createRemixHeaders
8c93d19 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(express): add basic test for createRemixRequest
52d0209 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(architect): add tests for headers
ba96473 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(vercel): extract headers conversion function, start adding tests…
97c515c 
… around it

Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(vercel): shutdown server after running test
e7e69fd 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
chore(architect): use requestContent protocol; add test for arc creat…
bbb6cd4 
…eRemixRequest

Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(architect): remove tes as I was handling it in the wrong direction
682e82d 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
chore: remove Object.fromEntries(responseHeaders) spreading
b97c453 
Signed-off-by: Logan McAnsh <[email protected]>
sergiodxa
sergiodxa reviewed Aug 10, 2021
View reviewed changes
docs/guides/styling.md Outdated Show resolved Hide resolved
@mcansh
test(express): update createRemixHeaders to support multiple headers …
8f5f397 
…with the same name

Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(vercel): add more tests
651f268 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
chore: ignore test directories when using tsc
f8f52ab
@mcansh
feat(architect): make multi set-cookie headers work
01e5134 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
feat(vercel): make multi set-cookie headers work
091448f 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(architect): add tests for createRemixRequest
6356ca3 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(vercel): add test for createRequestHandler
739084c 
vercel requests are regular http IncomingMessages but with various methods on it to make it more like express, so we'll just treat it like express..

Signed-off-by: Logan McAnsh <[email protected]>
@mcansh mcansh requested a review from mjackson August 11, 2021 20:28
@mcansh
test(vercel): use supertest for better header testing
d7cbc23 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
chore(deps/vercel): add @types/supertest
63017e0 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(express,vercel): bring tests to parity
a0b21a4 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
fix(express): read port from request app settings
fc40826 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
fix(express): req.get("host") returns the port
5a92783 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
test(express): update request mocking
c291fd7 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
Merge branch 'dev' into logan/rem-179-node-adapter-tests
9c640ab
@mcansh
chore: update notes
7b8a3dd
@mcansh
fix(express): im dumb
9b7a9b8 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh mcansh requested a review from mjackson August 13, 2021 22:58
@mcansh mcansh changed the title WIP: add and update node adapter tests feat: add and update node adapter tests Aug 16, 2021
mjackson
mjackson requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We just need to resolve merge conflicts with Jacob's branch and figure out what to do about the headers in remix-node/headers.ts. I'll help you get this done today 👍

packages/remix-node/headers.ts Outdated Show resolved Hide resolved
packages/remix-vercel/server.ts Outdated Show resolved Hide resolved
packages/remix-vercel/server.ts Show resolved Hide resolved
mjackson
mjackson approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's meeeeeeeeeerge 🚢

@mcansh
chore: update changelog
7df7d19 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh mcansh merged commit 9d3b090 into dev Aug 18, 2021
@mcansh mcansh deleted the logan/rem-179-node-adapter-tests branch August 18, 2021 18:12
@mcansh mcansh mentioned this pull request Mar 30, 2022
Closed
@brophdawg11 brophdawg11 mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa left review comments

@kentcdodds kentcdodds kentcdodds left review comments

@mjackson mjackson mjackson approved these changes

Assignees
No one assigned
Labels
package:dev package:server-runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcansh @mjackson @sergiodxa @kentcdodds @MichaelDeBoey