Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(remix-server-runtime): make AppLoadContext an empty interface instead of any #1876

Merged
merged 5 commits into from
Aug 2, 2022
Merged

types(remix-server-runtime): make AppLoadContext an empty interface instead of any #1876

merged 5 commits into from
Aug 2, 2022

Commits on Aug 1, 2022

  1. make AppLoadContext an empty interface

    @DanielFGray @pcattori
    DanielFGray authored and pcattori committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    87d2eaa View commit details
    Browse the repository at this point in the history

  2. Update contributors.yml

    @DanielFGray @pcattori
    DanielFGray authored and pcattori committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    296dc0c View commit details
    Browse the repository at this point in the history

  3. AppLoadContext interface uses unknown for missing values

    @DanielFGray @pcattori
    DanielFGray authored and pcattori committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ad9987f View commit details
    Browse the repository at this point in the history

  4. update types for AppLoadContext

    @DanielFGray @pcattori
    DanielFGray authored and pcattori committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    a8c3f9d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. fix: make AppLoadContext parameter optional 

    parameter used to be implicitly optional as it used to be typed as `any`. it _is_ intended to be
optional, so this restores it as an optional param
    @pcattori
    pcattori committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    33fd91b View commit details
    Browse the repository at this point in the history