feat(headers): sync SuperHeaders with native Headers#10889
Closed
alexandredev3 wants to merge 3 commits intoremix-run:mainfrom
Closed
feat(headers): sync SuperHeaders with native Headers#10889alexandredev3 wants to merge 3 commits intoremix-run:mainfrom
SuperHeaders with native Headers#10889alexandredev3 wants to merge 3 commits intoremix-run:mainfrom
Conversation
SuperHeaders with native Headers
Member
|
Thanks for raising this issue. I further explored what a complete solution would look like here: #10904. This most notably adds support for detecting mutations to header property accessors, e.g. As a result, we've opted instead to simplify the model, avoiding subclassing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR synchronizes
SuperHeaderswith the parentHeadersclass to ensure compatibility with Bun.Previously,
SuperHeadersstored data only in its internal#mapwithout updating the parentHeadersstate. As a result, when running on Bun, the Response constructor would receive empty headers.This appears to be because Bun accesses the parent
Headersclass's internal storage directly, bypassing overridden methods. Other runtimes, such as Node.js, seem to rely on JavaScript-level methods likeentries(), which is why they behaved correctly.The most reliable solution found was to explicitly call methods like
super.append,super.set, andsuper.deletealongside the internal updates to make Headers state visible to Bun.resolves #10872