Skip to content

Commit

Permalink
chore: stop modifying user tsconfig (#6156)
Browse files Browse the repository at this point in the history
Signed-off-by: Logan McAnsh <[email protected]>
  • Loading branch information
mcansh committed Apr 27, 2023
1 parent 10b0399 commit dd0c23f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 347 deletions.
6 changes: 6 additions & 0 deletions .changeset/tsconfig-no-modify.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"remix": patch
"@remix-run/dev": patch
---

stop modifying a user's tsconfig when running using `getConfig` (`remix dev`, `remix routes`, `remix build`, etc)
169 changes: 0 additions & 169 deletions integration/tsconfig-test.ts

This file was deleted.

5 changes: 0 additions & 5 deletions packages/remix-dev/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import type { RouteManifest, DefineRoutesFunction } from "./config/routes";
import { defineRoutes } from "./config/routes";
import { defineConventionalRoutes } from "./config/routesConvention";
import { ServerMode, isValidServerMode } from "./config/serverModes";
import { writeConfigDefaults } from "./config/write-tsconfig-defaults";
import { serverBuildVirtualModule } from "./compiler/server/virtualModules";
import { flatRoutes } from "./config/flat-routes";
import { detectPackageManager } from "./cli/detectPackageManager";
Expand Down Expand Up @@ -733,10 +732,6 @@ export async function readConfig(
tsconfigPath = rootJsConfig;
}

if (tsconfigPath) {
writeConfigDefaults(tsconfigPath);
}

let future: FutureConfig = {
unstable_dev: appConfig.future?.unstable_dev ?? false,
unstable_postcss: appConfig.future?.unstable_postcss === true,
Expand Down
173 changes: 0 additions & 173 deletions packages/remix-dev/config/write-tsconfig-defaults.ts

This file was deleted.

0 comments on commit dd0c23f

Please sign in to comment.