Skip to content

Commit

Permalink
feat!(remix-dev): remove browserBuildDirectory config
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelDeBoey committed Mar 16, 2023
1 parent 2f095cd commit 9cc0f7a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 19 deletions.
5 changes: 5 additions & 0 deletions .changeset/silver-readers-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": major
---

remove `browserBuildDirectory` config
20 changes: 1 addition & 19 deletions packages/remix-dev/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,6 @@ export interface AppConfig {
*/
assetsBuildDirectory?: string;

/**
* The path to the browser build, relative to remix.config.js. Defaults to
* "public/build".
*
* @deprecated Use `{@link AppConfig.assetsBuildDirectory}` instead
*/
browserBuildDirectory?: string;

/**
* The URL prefix of the browser build with a trailing slash. Defaults to
* `"/build/"`. This is the path the browser will use to find assets.
Expand Down Expand Up @@ -490,14 +482,8 @@ export async function readConfig(
? path.resolve(appDirectory, userEntryServerFile)
: path.resolve(defaultsDirectory, entryServerFile);

if (appConfig.browserBuildDirectory) {
warnOnce(browserBuildDirectoryWarning, "browserBuildDirectory");
}

let assetsBuildDirectory =
appConfig.assetsBuildDirectory ||
appConfig.browserBuildDirectory ||
path.join("public", "build");
appConfig.assetsBuildDirectory || path.join("public", "build");

let absoluteAssetsBuildDirectory = path.resolve(
rootDirectory,
Expand Down Expand Up @@ -678,10 +664,6 @@ let listFormat = new Intl.ListFormat("en", {
type: "conjunction",
});

export let browserBuildDirectoryWarning =
"⚠️ DEPRECATED: The `browserBuildDirectory` config option is deprecated. " +
"Use `assetsBuildDirectory` instead.";

export let serverBuildDirectoryWarning =
"⚠️ DEPRECATED: The `serverBuildDirectory` config option is deprecated. " +
"Use `serverBuildPath` instead.";
Expand Down

0 comments on commit 9cc0f7a

Please sign in to comment.