Fix tests

remix-run · Aug 21, 2023 · 23516c9 · 23516c9
1 parent f147226
commit 23516c9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/integration/error-sanitization-test.ts b/integration/error-sanitization-test.ts
@@ -500,7 +500,11 @@ test.describe("Error Sanitization", () => {
               ) {
                 console.error("App Specific Error Logging:");
                 console.error("  Request: " + request.method + " " + request.url);
-                if (error instanceof Error) {
+                if (isRouteErrorResponse(error)) {
+                  console.error("  Status: " + error.status + " " + error.statusText);
+                  console.error("  Error: " + error.error.message);
+                  console.error("  Stack: " + error.error.stack);
+                } else if (error instanceof Error) {
                   console.error("  Error: " + error.message);
                   console.error("  Stack: " + error.stack);
                 } else {
@@ -647,11 +651,12 @@ test.describe("Error Sanitization", () => {
       expect(errorLogs[1][0]).toEqual(
         "  Request: GET test://test/?_data=not-a-route"
       );
-      expect(errorLogs[2][0]).toEqual(
+      expect(errorLogs[2][0]).toEqual("  Status: 403 Forbidden");
+      expect(errorLogs[3][0]).toEqual(
         '  Error: Route "not-a-route" does not match URL "/"'
       );
-      expect(errorLogs[3][0]).toMatch(" at ");
-      expect(errorLogs.length).toBe(4);
+      expect(errorLogs[4][0]).toMatch(" at ");
+      expect(errorLogs.length).toBe(5);
     });
   });
 });
diff --git a/packages/remix-server-runtime/server.ts b/packages/remix-server-runtime/server.ts
@@ -51,7 +51,7 @@ export const createRequestHandler: CreateRequestHandlerFunction = (
     build.entry.module.handleError ||
     ((error, { request }) => {
       if (serverMode !== ServerMode.Test && !request.signal.aborted) {
-        console.error(error);
+        console.error(isRouteErrorResponse(error) ? error.error : error);
       }
     });