Normalize search + hash strings in resolvePath
#7953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjackson
requested changes
Aug 17, 2021
| function Home() { | ||
| path = useResolvedPath({ | ||
| pathname: "/home", | ||
| search: new URLSearchParams({ user: "mj" }).toString(), |
There was a problem hiding this comment.
You could also just do:
search: "?user=mj"which I think is a little more direct. Unless ofc you're trying to test the behavior of URLSearchParams#toString, which it doesn't seem like.
There was a problem hiding this comment.
I was writing the test as I figured a user might write their code, as they did in the root issue, but that would translate to search: "user=mj" I believe, yeah?
| function handleClick() { | ||
| navigate({ | ||
| pathname: "../about", | ||
| search: new URLSearchParams({ user: "mj" }).toString() |
There was a problem hiding this comment.
Same comment as below about just using "?user=mj" as your search value.
There was a problem hiding this comment.
Same response, I was trying to write these as a user might (a la #7496) but if you feel strongly about it I can change them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7496