Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use PureComponent to avoid useless re-renders (fixes #7248) #7258

Merged
merged 1 commit into from
Apr 14, 2020
Merged

perf: Use PureComponent to avoid useless re-renders (fixes #7248) #7258

merged 1 commit into from
Apr 14, 2020

Conversation

theboolean
Copy link
Contributor

No description provided.

@theboolean theboolean mentioned this pull request Apr 14, 2020
Closed
@timdorr
Copy link
Member

timdorr commented Apr 14, 2020

Thanks!

@timdorr timdorr merged commit bfe0d2b into remix-run:master Apr 14, 2020
@mjackson
Copy link
Member

React.PureComponent is an optimization that has a tendency to actually make things slower when used everywhere due to the extra computation needed to compare incoming props. Because of this tendency we have always avoided using React.PureComponent in our library code. Instead, we encourage people to profile their apps and insert React.PureComponent judiciously as needed.

I'm going to revert this change.

mjackson added a commit that referenced this pull request May 11, 2020
@mjackson
Revert "perf: Use PureComponent to avoid useless re-renders (#7258)"
baf755b 
This reverts commit bfe0d2b.
@mjackson mjackson mentioned this pull request May 11, 2020
Merged
mjackson added a commit that referenced this pull request May 11, 2020
@mjackson
Revert "perf: Use PureComponent to avoid useless re-renders (#7258)" (#…
7d64842 
…7328)

This reverts commit bfe0d2b.
This was referenced Mar 16, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theboolean @timdorr @mjackson