Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup config/deps #5454

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Update rollup config/deps #5454

merged 1 commit into from
Aug 22, 2017

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Aug 22, 2017

I went ahead and updated all of the outdated Rollup dependencies, although my main reason for doing this is that my PR to rollup-plugin-commonjs was just merged and it makes the UMD builds a lot more readable. Instead of there being lots of index$1, index$2, etc. variable names (because they come from index.js files), those variables are now named using their parent directory.

Previous:

var index$6 = Array.isArray || function (arr) {
  return Object.prototype.toString.call(arr) == '[object Array]';
};

if (!index$6(keys)) {
  options = /** @type {!Object} */ (keys || options);
  keys = [];
}

Now:

var isarray = Array.isArray || function (arr) {
  return Object.prototype.toString.call(arr) == '[object Array]';
};

if (!isarray(keys)) {
  options = /** @type {!Object} */ (keys || options);
  keys = [];
}

@timdorr
Copy link
Member

timdorr commented Aug 22, 2017

Oh nice! Thanks for doing this. I'll have to get it into Redux too!

@timdorr timdorr merged commit fe16632 into remix-run:master Aug 22, 2017
@pshrmn pshrmn deleted the rollupdate branch August 22, 2017 16:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants