-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BrowserStack config #3678
Fix BrowserStack config #3678
Conversation
Bleh, I might just disable BrowserStack for now until @mjackson can tell me how to do this correctly 😄 We're not directly accessing browser APIs anyway except via history, so it's sort of "good enough" that we have coverage via history. |
Huh, Coveralls decided that it should do something now. Weird. |
That's because you're running the tests locally, so it can collect the stats coveralls uses now. We've got one brower API use now, but not significant enough to test this across a handful of browsers and have to maintain the versions of those browsers used in the suite. I'd say nuke them and rely on the basic browser versions on Travis. |
Gah it's busted on history too: https://travis-ci.org/ReactTraining/history/builds/144879254 The last commit sets us up to run on Firefox and Chrome on Travis. Seems okay. Congrats BTW (: |
I've emailed BrowserStack to see if we can figure out what's going on. I'd rather keep the tests running on BrowserStack, but it has been pretty flaky lately... |
BrowserStack has renewed my subscription. They sponsor us, and the sponsorship had expired. I'm going to follow up w them so this hopefully doesn't happen again in a few years. |
Cool... I also got the Codecov status thing fixed. Their patch status is a neat surface-level check to filter out new code that doesn't have adequate test coverage. Might turn off Coveralls entirely. Gonna merge since this is just a tooling chore to align with history. |
After remix-run/history@b7152a4.