Skip to content

Escape locations in prerendered redirect HTML #14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brophdawg11 merged 1 commit into from
Mar 17, 2026
Merged

Escape locations in prerendered redirect HTML #14880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-shirts-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-router/dev": patch
---

Escape redirect locations in prerendered redirect HTML
35 changes: 27 additions & 8 deletions packages/react-router-dev/vite/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2752,15 +2752,17 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => {
// A short delay causes Google to interpret the redirect as temporary.
// https://developers.google.com/search/docs/crawling-indexing/301-redirects#metarefresh
let delay = response.status === 302 ? 2 : 0;
let escapedLocation = escapeHtml(location ?? "");
let escapedPathname = escapeHtml(pathname);
html = `<!doctype html>
<head>
<title>Redirecting to: ${location}</title>
<meta http-equiv="refresh" content="${delay};url=${location}">
<title>Redirecting to: ${escapedLocation}</title>
<meta http-equiv="refresh" content="${delay};url=${escapedLocation}">
<meta name="robots" content="noindex">
</head>
<body>
<a href="${location}">
Redirecting from <code>${pathname}</code> to <code>${location}</code>
<a href="${escapedLocation}">
Redirecting from <code>${escapedPathname}</code> to <code>${escapedLocation}</code>
</a>
</body>
</html>`;
Expand Down Expand Up @@ -3345,15 +3347,17 @@ async function prerenderRoute(
// A short delay causes Google to interpret the redirect as temporary.
// https://developers.google.com/search/docs/crawling-indexing/301-redirects#metarefresh
let delay = response.status === 302 ? 2 : 0;
let escapedLocation = escapeHtml(location ?? "");
let escapedNormalizedPath = escapeHtml(normalizedPath);
html = `<!doctype html>
<head>
<title>Redirecting to: ${location}</title>
<meta http-equiv="refresh" content="${delay};url=${location}">
<title>Redirecting to: ${escapedLocation}</title>
<meta http-equiv="refresh" content="${delay};url=${escapedLocation}">
<meta name="robots" content="noindex">
</head>
<body>
<a href="${location}">
Redirecting from <code>${normalizedPath}</code> to <code>${location}</code>
<a href="${escapedLocation}">
Redirecting from <code>${escapedNormalizedPath}</code> to <code>${escapedLocation}</code>
</a>
</body>
</html>`;
Expand Down Expand Up @@ -4328,3 +4332,18 @@ function createSpaModeRequest(
metadata: { type: "spa", path: "/" },
};
}

// Note: Duplicated from react-router/lib/dom/ssr/markup
// Must be kept in sync with the original implementation.
const ESCAPE_REGEX = /[&><\u2028\u2029]/g;
const ESCAPE_LOOKUP: { [match: string]: string } = {
"&": "\\u0026",
">": "\\u003e",
"<": "\\u003c",
"\u2028": "\\u2028",
"\u2029": "\\u2029",
};

function escapeHtml(html: string) {
return html.replace(ESCAPE_REGEX, (match) => ESCAPE_LOOKUP[match]);
}
Loading