Skip to content

refactor(react-router): replace substr with substring #12080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

refactor(react-router): replace substr with substring #12080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e913761
Replaced deprecated subtr method with substring in history package
bilalk711 Oct 20, 2024
cf98cde
Update .changeset/silver-cats-shave.md
MichaelDeBoey Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-cats-shave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-router": patch
---

Replace `substr` with `substring`
12 changes: 6 additions & 6 deletions packages/react-router/lib/router/history.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ export function createHashHistory(
pathname = "/",
search = "",
hash = "",
} = parsePath(window.location.hash.substr(1));
} = parsePath(window.location.hash.substring(1));

// Hash URL should always have a leading / just like window.location.pathname
// does, so if an app ends up at a route like /#something then we add a
Expand Down Expand Up @@ -510,7 +510,7 @@ export function warning(cond: any, message: string) {
}

function createKey() {
return Math.random().toString(36).substr(2, 8);
return Math.random().toString(36).substring(2, 10);
}

/**
Expand Down Expand Up @@ -576,14 +576,14 @@ export function parsePath(path: string): Partial<Path> {
if (path) {
let hashIndex = path.indexOf("#");
if (hashIndex >= 0) {
parsedPath.hash = path.substr(hashIndex);
path = path.substr(0, hashIndex);
parsedPath.hash = path.substring(hashIndex);
path = path.substring(0, hashIndex);
}

let searchIndex = path.indexOf("?");
if (searchIndex >= 0) {
parsedPath.search = path.substr(searchIndex);
path = path.substr(0, searchIndex);
parsedPath.search = path.substring(searchIndex);
path = path.substring(0, searchIndex);
}

if (path) {
Expand Down