Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive Path example throws an error. #7272

Closed
vicary opened this issue Apr 20, 2020 · 1 comment · Fixed by newerton/gostack-template-fundamentos-reactjs#26
Closed

Recursive Path example throws an error. #7272

vicary opened this issue Apr 20, 2020 · 1 comment · Fixed by newerton/gostack-template-fundamentos-reactjs#26

Comments

@vicary
Copy link
Contributor

vicary commented Apr 20, 2020

Version

Latest? The version bundled in https://reacttraining.com/react-router/native/example/recursive-paths as of the time of writing.

Test Case

https://codesandbox.io/s/react-router-recursive-paths-h74vx

The sandbox directly embedded in the official website.

Steps to reproduce

Just open it.

Expected Behavior

Not throw.

Actual Behavior

Array.find() doesn't like that your path param id is a string, while having the actual data in number.
@timdorr
Copy link
Member

timdorr commented Apr 20, 2020

The web example works fine: https://reacttraining.com/react-router/web/example/recursive-paths

We just haven't updated the RN version. Want to make a PR?

@timdorr timdorr closed this as completed Apr 20, 2020
vicary added a commit to vicary/react-router that referenced this issue Apr 20, 2020
@vicary
Fixes remix-run#7272
bcf8415
timdorr pushed a commit that referenced this issue Apr 21, 2020
@vicary
Fixes #7272 (#7274)
26aa871
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timdorr @vicary