PropType validators error when an external lib bundles prop-types (v3)

[zekedroid]

Similar to #3988

I'm seeing the prop validation failures again on v3.2.0 after upgrading from v3.0.1.

The behavior I see is that in a previous version of react-router (v3.0.1) I don't see the error log. When upgrading JUST react-router to v3.2.0 I start to see the prop validation errors.

I also did an incremental upgrade to see when this error was reintroduced and it looks like up to v3.0.3 the router worked with no problems, but at v3.0.4 the validation errors started appearing again.

I didn't see any other closed/open issues on v3 having these issues so I thought I'd point it out since it would be sweet to upgrade to v3.2.0!

[timdorr]

What specific error are you seeing?

[zekedroid]

Several times repeated the following are the top ones for v3.2.0

Warning: Failed propType: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types

Warning: Failed Context Types: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types Check the render method of `Router`.

Warning: Failed Context Types: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types Check the render method of `RouterContext`.

And for v3.0.5 there are way more, though they are more informative. Here are a couple:

Warning: You are manually calling a React.PropTypes validation function for the `component` prop on `Route`. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the `path` prop on `Route`. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

and many more on what looks to be every method and property of the router.

Note that I'm using history v3.3.0 though I see no difference on any version of a history v3 object.

[timdorr]

Closing this out as this is always caused by something in the build process or outside of React Router. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!

[zekedroid]

Yup, I went there first but given this had appeared in an issue in this repo I could only reason that it had to do with react-router. You were right, and it seems like the issue is using a version of react that is <0.14.9. Thanks for pointing it out, @timdorr

For those that are curious, here is the exact issue discussing this topic.

reduxjs/react-redux#669