Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a route of name 'watch' blows up in Firefox #3679

Closed
tony99nyr opened this issue Jul 28, 2016 · 4 comments · Fixed by #3680
Closed

Using a route of name 'watch' blows up in Firefox #3679

tony99nyr opened this issue Jul 28, 2016 · 4 comments · Fixed by #3680
Labels

Comments

@tony99nyr
Copy link

Version

2.6.0

Test Case

http://jsbin.com/yibililodo/edit?html,js,output

Steps to reproduce

Firefox >45
Have a nested path of 'watch' or 'unwatch'
Use router.push() to navigate to them.

Expected Behavior

Routes to the watch route.

Actual Behavior

Blows up.

Firefox apparently has a watch and unwatch function on every object. Because of this, when PatternUtils.compilePattern() is hit when pattern = 'watch' it returns the watch function. Then when trying to call paramNames.some() in computeChangesRoutes.js it blows up since some() can't be called on a function.

@taion
Copy link
Contributor

taion commented Jul 28, 2016

Thanks. That's a funny little bug.

@taion
Copy link
Contributor

taion commented Jul 29, 2016

There's a minor "TODO" here where we may want to use consistent prefixing behavior everywhere, so we get the most we can out of our cache.

@taion
Copy link
Contributor

taion commented Jul 29, 2016

Fix released in v2.6.1.

@tony99nyr
Copy link
Author

Thanks guys!

On Fri, Jul 29, 2016, 7:53 PM Jimmy Jia [email protected] wrote:

Fix released in v2.6.1.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3679 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0Gd_kFNiOtXR3uMGhegDDl6xonV8dkks5qapJqgaJpZM4JXgaa
.

Thanks,
Tony Rossi

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants