Skip to content

Commit

Permalink
fixed createURL() for Firefox (#9464)
Browse files Browse the repository at this point in the history
* fixed createURL() for Firefox

* Update contributors.yml
  • Loading branch information
AchThomas authored Oct 24, 2022
1 parent 7dc7f35 commit 2699759
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions contributors.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- abdallah-nour
- abhi-kr-2100
- AchThomas
- Ajayff4
- alany411
- alexlbr
Expand Down
7 changes: 6 additions & 1 deletion packages/router/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3060,8 +3060,13 @@ function getTargetMatch(
}

function createURL(location: Location | string): URL {
// window.location.origin is "null" (the literal string value) in Firefox under certain conditions
// https://bugzilla.mozilla.org/show_bug.cgi?id=878297
// this breaks the app when a production build is served from the local file system
let base =
typeof window !== "undefined" && typeof window.location !== "undefined"
typeof window !== "undefined" &&
typeof window.location !== "undefined" &&
window.location.origin !== "null"
? window.location.origin
: "unknown://unknown";
let href =
Expand Down

0 comments on commit 2699759

Please sign in to comment.