Skip to content

Conversation

@penx
Copy link
Contributor

@penx penx commented Sep 16, 2022

Reopening remix-run/remix#3398 against remix-run/examples

Deploy to firebase functions and hosting

Closes: Discussion at remix-run/remix#1811 (comment)

  • Docs
  • Tests (I'd happily add Playwright tests if you want these on examples)

Testing Strategy:

  • Testing locally against emulator with JS enabled and disabled
  • Testing locally against production with JS enabled and disabled
  • Following deploy instructions and testing remote with JS enabled and disabled

@MichaelDeBoey MichaelDeBoey changed the title feat(examples/firebase): deploy to Cloud Functions for Firebase feat(firebase): deploy to Cloud Functions for Firebase Sep 16, 2022
@penx penx force-pushed the firebase-functions branch from a8f2e39 to 959de20 Compare October 4, 2022 20:22
@MichaelDeBoey
Copy link
Member

@penx Could you please fix the ESLint warnings/errors?
Most of them will probably be fixed by running yarn lint:fix

Please also resolve conflicts.

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Oct 21, 2022
@github-actions
Copy link
Contributor

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this Oct 28, 2022
@penx
Copy link
Contributor Author

penx commented Oct 31, 2022

@MichaelDeBoey fixed, please could you reopen? 7 days is a bit short to close :)

I had resolved issues and fixed conflicts on 4 Oct but have pushed another rebase

@machour
Copy link
Collaborator

machour commented Oct 31, 2022

Same problem here, can't reopen on my side.

@penx
Copy link
Contributor Author

penx commented Oct 31, 2022

Reopened as #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-response We need a response from the original author about this issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants