chore: update examples to be in line with templates #40
Conversation
|
Sure @MichaelDeBoey, I'll update the Should I start now or wait for this PR to be reviewed? |
|
@sergiocarneiro Thanks! 🙏 |
|
It appears React 18 streaming support is still a work-in-progress for CSS-in-JS libraries. I found that at least The required changes are officially described here, for those who are interested: reactwg/react-18#110 |
MichaelDeBoey
force-pushed
the
bring-in-line-with-templates
branch
from
e864b20 to
6c35f48
Compare
MichaelDeBoey
force-pushed
the
bring-in-line-with-templates
branch
7 times, most recently
from
32fd2e7 to
d84740d
Compare
MichaelDeBoey
force-pushed
the
bring-in-line-with-templates
branch
from
d84740d to
37e9911
Compare
|
i'll review over lunch :) |
MichaelDeBoey
force-pushed
the
bring-in-line-with-templates
branch
from
37e9911 to
054150d
Compare
|
alright, just gonna take a look at the server entries on my computer as the git diff on mobile is a little much 😆 |
|
If it would make your life easier, I'm happy to chop this up in multiple PRs. |
| import type { EntryContext } from "@remix-run/node"; | ||
| import { Response } from "@remix-run/node"; |
There was a problem hiding this comment.
idk why I'm just noticing, but Response should be available globally and shouldn't need to be imported, but we can look at that another time
There was a problem hiding this comment.
ah right, has to do with the original global not accepting streams
There was a problem hiding this comment.
Since this all originated from @chaance's work in remix-run/remix#3917, he can probably give more insights
|
tried a few examples locally and of course the first one i tried happened to be sass which doesn't have any routes 🥴 |
|
@mcansh I'll add an |
@chaance You last updated the
chakra-uiexample, so you have some experience withemotion. Could you maybe look into theemotionexample as well?@helderberto Since you're the original creator of the
emotion&stitchesexamples, we would like to have your help as well.@kumard3 If you have time to update thestyled-componentsexample, we would like to welcome a PR for that.@sergiocarneiro If you could help us updating thestyletronexample, that would be awesome as well.@chaance @machour @mcansh If this PR is too big to review, I'm happy to chop this into a separate PR for each example.