-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to ESM #206
base: main
Are you sure you want to change the base?
feat: move to ESM #206
Conversation
d33184d
to
20dacf5
Compare
20dacf5
to
45c188f
Compare
45c188f
to
bdbf890
Compare
bdbf890
to
00117fe
Compare
4192c29
to
62dff68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have docker installed locally so I can't fully validate this, but the install and remix.init
run fine for me via npx create-remix --template https://github.com/MichaelDeBoey/blues-stack/tree/move-to-ESM temp
👌
When applying these changes to an existing Blues Stack, and running
Edit: Found a similar issue when starting the project from scratch (template init) as well. |
45c0f9f
to
d1d5d77
Compare
d1d5d77
to
a8442a5
Compare
@hs2323 Any idea how to solve that? 🤔 |
Not sure, it seems to be an issue with the server build. It doesn't like the require module:
When commenting out the exception catch, it produces the following error:
Line 44 of build/server.js
It seems that it can't read the require from the build. Most likely will require a rewrite of server.ts. |
Just like I did in remix-run/indie-stack#255
This will also need @mcansh's remix-run/remix#7348