Skip to content

Learneth UI improvement #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 5, 2025
Merged

Learneth UI improvement #6495

merged 8 commits into from
Nov 5, 2025

Conversation

@yann300
Copy link
Contributor

@yann300 yann300 commented Oct 26, 2025 •
edited
Loading

  • when a tutorial is marked as finished, label will be displayed.
  • improvement MD rendering.
  • create and switch to the "learneth workspace" instead of spamming the current workspace.

@netlify
Copy link

netlify bot commented Oct 26, 2025 •
edited
Loading

✅ Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit e2f6b0d
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/690b0ccc59cca00009e2ca1a
😎 Deploy Preview https://deploy-preview-6495--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yann300 yann300 added the ready-to-review PR ready to review label Oct 26, 2025
@yann300 yann300 changed the title save tutorial state Learneth UI improvement Oct 27, 2025
joeizang
joeizang approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Even though there are lint errors but it's good to me

@yann300 yann300 force-pushed the save_tuto_state branch 2 times, most recently from 4b358c0 to 210a1a7 Compare October 27, 2025 16:39
@yann300 yann300 enabled auto-merge October 27, 2025 16:39
@ryestew
Copy link
Collaborator

ryestew commented Oct 28, 2025 •
edited
Loading

When I finish a tutorial I get the finished badge - but at one of the standard widths, the formatting does not look good:
image
Maybe some kind of checkmark icon would do the trick instead of spelling out Finished

@yann300 yann300 disabled auto-merge October 28, 2025 09:05
@yann300 yann300 force-pushed the save_tuto_state branch 2 times, most recently from 7cbf557 to a78d46d Compare October 28, 2025 15:39
@nx-cloud
Copy link

nx-cloud bot commented Nov 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e2f6b0d

Command Status Duration Result
nx lint vyper ✅ Succeeded <1s View ↗
nx lint remixd ✅ Succeeded <1s View ↗
nx lint solhint ✅ Succeeded <1s View ↗
nx lint doc-gen ✅ Succeeded <1s View ↗
nx lint remix-ui ✅ Succeeded <1s View ↗
nx lint learneth ✅ Succeeded 1s View ↗
nx lint debugger ✅ Succeeded <1s View ↗
nx lint remix-lib ✅ Succeeded <1s View ↗
Additional runs (23) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-05 08:44:52 UTC

@ci-pr-comment
Copy link

ci-pr-comment bot commented Nov 5, 2025 •
edited
Loading

✅ E2E tests passed (workflow: web)

Last run: Thu, Nov 6, 2025, 09:25 AM UTC

All tests are now passing! Previous failures have been resolved.

@yann300 yann300 merged commit fdb095b into master Nov 5, 2025
34 checks passed
@yann300 yann300 deleted the save_tuto_state branch November 5, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeizang joeizang joeizang approved these changes

@ryestew ryestew ryestew approved these changes

@bunsenstraat bunsenstraat Awaiting requested review from bunsenstraat

Assignees

No one assigned

Labels

ready-to-review PR ready to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yann300 @ryestew @joeizang