Skip to content

Conversation

@hsy822
Copy link
Collaborator

@hsy822 hsy822 commented Oct 16, 2025

This PR resolves the inconsistency where the list of verifiers used during automatic deployment did not match the list available in the Contract Verification Plugin.

To ensure consistency, the automatic verification process now uses the same list of verifiers as the plugin.

fixes #6461

@netlify
Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit cd9d306
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/6909d8d4ec08860008b50111
😎 Deploy Preview https://deploy-preview-6462--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hsy822 hsy822 force-pushed the fix/missing-verifier-defaults branch from 279b0f0 to 042457c Compare October 22, 2025 00:33
@hsy822 hsy822 added the ready-to-review PR ready to review label Oct 22, 2025
@hsy822 hsy822 requested a review from Aniket-Engg October 22, 2025 00:45
@hsy822 hsy822 force-pushed the fix/missing-verifier-defaults branch 3 times, most recently from 7fb0543 to 8112e11 Compare October 29, 2025 07:38
@hsy822 hsy822 added WIP and removed ready-to-review PR ready to review labels Oct 29, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 29, 2025

View your CI Pipeline Execution ↗ for commit cd9d306

Command Status Duration Result
nx lint vyper ✅ Succeeded <1s View ↗
nx lint remixd ✅ Succeeded <1s View ↗
nx lint solhint ✅ Succeeded <1s View ↗
nx lint doc-gen ✅ Succeeded <1s View ↗
nx lint remix-ui ✅ Succeeded 9s View ↗
nx lint learneth ✅ Succeeded <1s View ↗
nx lint debugger ✅ Succeeded <1s View ↗
nx lint remix-lib ✅ Succeeded <1s View ↗
Additional runs (23) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-04 10:52:38 UTC

@ci-pr-comment
Copy link

ci-pr-comment bot commented Oct 29, 2025

✅ E2E tests passed (workflow: web)

Last run: Tue, Nov 4, 2025, 11:03 AM UTC

All tests are now passing! Previous failures have been resolved.

@hsy822 hsy822 added ready-to-review PR ready to review and removed WIP labels Oct 29, 2025
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that old issue to show red cross for routescan even on successful verification came back

@hsy822 hsy822 force-pushed the fix/missing-verifier-defaults branch from d12bb5a to 4437300 Compare November 4, 2025 01:40
@hsy822 hsy822 requested a review from Aniket-Engg November 4, 2025 05:33
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise looks fine

@hsy822 hsy822 force-pushed the fix/missing-verifier-defaults branch from da0b50e to b5419e3 Compare November 4, 2025 09:53
@hsy822 hsy822 force-pushed the fix/missing-verifier-defaults branch from b5419e3 to cd9d306 Compare November 4, 2025 10:43
@hsy822 hsy822 merged commit e2767bd into master Nov 4, 2025
34 checks passed
@hsy822 hsy822 deleted the fix/missing-verifier-defaults branch November 4, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review PR ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contract verifier list

3 participants