-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use captain to build #2
Comments
I need this as well to build multiple frontend images with different assets, filed: harbur/captain#31. I think the full commit sha is more of a nice to have, I'm going to start working on a branch that uses captain. |
@mhahn You can also just fork the |
yea i did that to use a more updated version of |
Intrigued and interested to see conveyor and captain work together. I can check the full-sha issue, would a flag-enabling option be sufficient for that? |
Yea, I think something similar to: would work |
@Spiddy any update on this? |
@ejholmes i started looking at this last night. I had some questions about how you would recommend structuring it. One option like you mentioned is to fork: https://github.com/remind101/conveyor/blob/master/builder/docker/bin/build and use captain instead. I wasn't sure how to integrate that into the current app structure or if i should just do it as a separate repo |
captain code is merged. It can be activated using |
thanks @Spiddy On Mon, Feb 1, 2016 at 2:22 AM spiddy [email protected] wrote:
|
@mhahn I think with long sha support, captain can just replace the shell commands that we have in ./bin/build. |
yea, i've started that here: https://github.com/lunohq/conveyor-builder-captain/blob/master/bin/build only regression is retrying docker push 3 times, i opened: harbur/captain#34 to track adding support for that in captain |
FYI, I just pulled out remind101/conveyor-builder to https://github.com/remind101/conveyor-builder. If we make any changes to the builder, that'll be the place to do it. |
Nice it felt weird inside this repo :)
|
Using captain in the default builder image would be nice for a couple of reasons:
Only thing that prevents this atm is that captain tags the docker image with a short sha instead of the full sha.
The text was updated successfully, but these errors were encountered: