Add per-player stats #34
Conversation
Adds the following metrics (can be disabled in settings): - factorio_player_connected[name]: 1 if the player is currently connected - factorio_player_last_online[name]: Last tick the player was connected - factorio_player_time_online[name]: Time (in seconds) the player spent online - factorio_player_position_x[name]: The x coordinate of the players (last) position - factorio_player_position_y[name]: The y coordinate of the players (last) position - factorio_player_position_surface[name, surface]: The surface of the players (last) position
|
Given that player names are in theory a high cardinality label, these new metrics should maybe be disabled by default, like the train metrics mentioned in #32 (although this case should be way less severe). |
| gauge_player_last_online = | ||
| prometheus.gauge("factorio_player_last_online", "last tick the player was online", { "name" }) | ||
| gauge_player_time_online = | ||
| prometheus.gauge("factorio_player_time_online", "total seconds player spent online", { "name" }) |
There was a problem hiding this comment.
i believe it should be a counter and not a gauge, the value can only go up
There was a problem hiding this comment.
sure, I was just matching the other calls - as far as I could tell (although I did not look at every file), all other currently added metrics are either gauges or histograms (even gauge_tick, of which these two are kind of 'subsets', so to speak).
There was a problem hiding this comment.
Also on that note, gauge_player_time_online and gauge_tick should be actively reset to 0 on start if they are turned into counters, no? Otherwise if the server crashes without saving, but still exported its metrics at least once since the last save, the observed value could appear to decrease on the real-world timescale, even if it is monotonically increasing in relation to game-ticks.
Another interpretation (aside from just "this case is irrelevant") could be that rate(factorio_tick) should not be used, because the value can, exactly as stated by its gauge nature, go down?
I will wait for further confirmation on this before changing the metrics to counters. If you want I can also go over the existing metrics and change their type where appropriate, although I dont know how well prometheus handles existing metrics changing their type.
|
Please dont merge this yet. Now that #37 is merged I can also include documentation for the metrics added in this PR to the Update: Done |
Adds the following metrics (can be disabled in settings):