fix: missing client capabilities and markdown descriptions #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems monaco-yaml does not set
clientCapabilities
while callinggetLanguageService
, which is exported by yaml-language-server. This causes thedoesSupportMarkdown
in yaml-language-server always returnundefined
and makes themarkdownDescription
not being correctly rendered in the completion item.However, I can see
clientCapabilities
is being set by the test helper in yaml-language-server with a constant imported from vscode-json-languageservice.Similiar usage in
jsonWorker
inmonaco-editor
can be found here: https://github.com/microsoft/monaco-editor/blob/f6dc0eb8fce67e57f6036f4769d92c1666cdf546/src/language/json/jsonWorker.ts#L38This pull request copied the
clientCapabilities
constant from vscode-json-languageservice to avoid introducing new dependencies.