Select highest quality available if no FLAC found #3056
Conversation
This sends an API search for the "Audio" category instead of the "Audio Flac" category. This fixes an issue where an MP3 file would not be selected if available but no Flac file was available.
|
Yasssss! |
|
I think this is a good feature, but maybe they want you to do a pull request against the develop branch instead. |
|
I'm a noob to github and coding in general so not sure how to do a pull. I will try to look into it over the next couple of days. |
|
So the mp3 is in the wrong category? Isn't this just a problem with the provider you're using? |
|
@AdeHub No, it isn't a problem with any indexer I'm using. I have plenty running under nzbhydra2. The problem is with the category code in the searcher.py file. When selecting 'Highest Quality including Lossless' under the 'Quality & Post Processing' setting the expected behavior is to select an mp3 file to download if no FLAC happens to be found. Instead, what happens is that if no FLAC files are returned after a search nothing is sent to my downloader even though mp3 files were returned for that search. Selecting this option should check if a FLAC file is available and upon not finding one then select the available mp3 file. As is, this option seems to act like the 'Lossless Only' setting. |
|
Seems to work for me |
|
I can backup what jaywk is describing. I've seen this happen myself and would confirm that it arises when it finds both flac and mp3, but the flac download has failed and been marked as bad in Headphones... it will not always fallback to an mp3 copy. I don't have my headphones running at the moment, otherwise I'd try and recreate it again -- but I did confirm this was an issue for me and I saw it happen multiple times. I'd have to end up bypassing headphones all together. I would go to my NZB Hydra installation, and take the search Headphones did and re-do it manually, then force download the album, bypassing headphones. |
This sends an API search for the "Audio" category instead of the "Audio Flac" category. This fixes an issue where an MP3 file would not be selected if available but no Flac file was available.