LMS Error reporting and code cleanup #1564
Conversation
Even upon successful rescan, the code would throw a keyerror back. Not certain why, but LMS sends some really weird unicode JSON back as its result, unlike XBMC, so having response[0]['result'] will always throw back a keyerror. Removing the key, however, and just asking the return to find 'result' works fine.
Squeezebox is an old unused name, and LMS isn't very self-explanitory.
|
can you just double check that i merged this in right? there was a merge conflict and i'm not 100% sure. just notifiers.py cheers! |
|
merged into the develop branch, btw |
|
There is still a glitch in the error reporting. Command to LMS was successfully given (LMS did a rescan) but log headphones shows otherwise: |
|
Confirmed that LMS is still reporting an error, though not to the extent it used to; not sure how I missed it when I tested my code. Must have been late. As long as LMS is correctly updating, pretty much all is well. I'll fix that bit of code as soon as I can, but at least it still works for now. Cheers for letting me know. And rembo10, I checked the merge as you asked me and didn't notice any problems with it, so I'll keep my eyes on it and see if anything develops. |
|
Just checking in to report that the wrong error report is still not fixed. |
|
Thanks for the comment EvtK. RL caught up with me this year and I totally forgot to address this issue. Should now be patched finally in #2048. |
|
cool.. thanks! |
Found that my LMS code was reporting errors to the logger even upon success. Cleaned that up, and also streamlined the original code a little.
Also changed the title in the config options. Referring to the system as LMS is alright when you know what LMS stands for, but using it as the title is a bit daft for people who may not know what LMS is at first glance. Similarly, using 'Squeezebox' is also a bit redundant based on that being an old disused name.