Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esm): fix ESM types by adding esm/index.d.mts #207

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Dec 1, 2023

What is the motivation for this pull request?

Fixes #205

  • Fix ESM types by adding esm/index.d.mts
  • Remove unnecessary types fields in package.json

What is the current behavior?

ESM types are wrong

What is the new behavior?

Export esm/index.d.mts

Checklist:

@remarkablemark remarkablemark self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7201290) 100.00% compared to head (73ae1d4) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           18        18           
  Branches         5         5           
=========================================
  Hits            18        18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark merged commit 296e830 into master Dec 1, 2023
9 checks passed
@remarkablemark remarkablemark deleted the fix/esm branch December 1, 2023 02:55
@remarkablemark
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM types are wrong
1 participant