-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): add domhandler to dependencies #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you amend your commit message so it's more descriptive?
git commit --amend -m 'fix(package): add domhandler to dependencies' -m 'Fixes #240'
git push -f
package.json
Outdated
@@ -37,6 +37,7 @@ | |||
"dom" | |||
], | |||
"dependencies": { | |||
"domhandler": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind making this an exact dependency? 4.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for opening this PR @kfritsch
@kfritsch I'll make a release later tonight |
Published v1.2.5: npm: npm i [email protected] Yarn: yarn add [email protected] |
added missing dependency for "domhandler": "^4.0.0"
fixes #231
Checklist:
Explanation can be found in the issue. Only tested the workaround explained in the issue.