Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): add domhandler to dependencies #240

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

kfritsch
Copy link
Contributor

added missing dependency for "domhandler": "^4.0.0"

fixes #231

Checklist:

  • Tests
  • Documentation
  • Types

Explanation can be found in the issue. Only tested the workaround explained in the issue.

@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 88cb7ad on kfritsch:master into 655ba59 on remarkablemark:master.

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you amend your commit message so it's more descriptive?

git commit --amend -m 'fix(package): add domhandler to dependencies' -m 'Fixes #240'
git push -f

package.json Outdated
@@ -37,6 +37,7 @@
"dom"
],
"dependencies": {
"domhandler": "^4.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind making this an exact dependency? 4.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at all

@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Apr 12, 2021
@remarkablemark remarkablemark self-assigned this Apr 12, 2021
@remarkablemark remarkablemark changed the title fix: #231 fix(package): add domhandler to dependencies Apr 12, 2021
Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for opening this PR @kfritsch

@remarkablemark remarkablemark merged commit 065aed7 into remarkablemark:master Apr 12, 2021
@remarkablemark
Copy link
Owner

@kfritsch I'll make a release later tonight

@remarkablemark
Copy link
Owner

Published v1.2.5:

npm:

Yarn:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module '"../@types/domhandler"' has no exported member
3 participants