Module '"../@types/domhandler"' has no exported member

[fabienbranchel]

Expected Behavior

Run OK

Actual Behavior

Run KO

Steps to Reproduce

When used with TypeScript (4.1.5), it's suggest to install @types/domhandler and @types/htmlparser2.

It's fine. But when it's done, I've got these errors :

Environment

• Version: 1.2.4
• Platform: macOS
• Browser: Chrome

[remarkablemark]

@fabienbranchel can you import the types without using @types?

import { Comment, ProcessingInstruction, Text } from 'html-react-parser';

See index.d.ts.

[fabienbranchel]

I tried, it's not resolving the issue.
Moreover, it's doesn't feel right to import something I don't use directly.

[remarkablemark]

So domhandler exports its own types so installing @types/domhandler may be unnecessary.

Can you provide a reproducible example using CodeSandbox?

[kfritsch]

Fix

Hey I got the same Issue. I think the fix would be adding domhandler ^4.0.0 as a dependency.

Explanation

The problem seems to be that this package uses "domhandler" directly but does not have it as a direct dependency. It only has it as an indirect dependency via "html-dom-parser". This can cause problems with the way npm installs packages. If another package requires an older version of "domhandler" and is installed first it will be placed at the root level of node_modules. Since this package does not have an explicit dependency on "domhandler" it will use what is installed at the root level. That "html-dom-parser" uses the required newer version does not help since this version is now placed inside "html-dom-parser".

• /node_modules
  • /domhandler (v3.0.0)
  • /html-dom-parser
    • /domhandler (v.4.0.0)
  • /html-react-parser

Workaround

The installation of the old "domhandler" 3.0.0 is actually triggered by the dependencies of this module. This means that the only other workaround would be adding "domhandler" ^4.0.0 before "html-react-parser" in the dependencies so it ends up at the root level.

[remarkablemark]

@kfritsch Thanks for opening the PR. I left some comments.

[remarkablemark]

@fabienbranchel @kfritsch I'll make a release later tonight for #240

[remarkablemark]

Published v1.2.5:

npm:

npm i [email protected]

Yarn:

yarn add [email protected]