Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ISO 8601 parsing #26

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Better ISO 8601 parsing #26

merged 1 commit into from
Sep 23, 2024

Conversation

jakozaur
Copy link
Contributor

There are several more valid date formats which this library does not support:
E.g. 2017-02 is a valid ISO 8601 date.

See:
https://en.wikipedia.org/wiki/ISO_8601
https://ijmacd.github.io/rfc3339-iso8601/

So that you know, this library has yet to support more valid date formats. See week dates or ordinal dates.

@relvacode
Copy link
Owner

You are right, the purpose of this library has always been to improve interop with other languages which don't exactly conform to RFC3339 with minimal overhead and avoid using extensive regexp patterns like other libraries. Perhaps that should be on the README.

Anyway, thanks. Happy to take more PRs if there's something else you need. Week and ordinal dates are likely to add a lot more complexity as they can't just be passed off to time.Date

@relvacode relvacode merged commit 125e13f into relvacode:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants