Merged
Conversation
isactornberg
approved these changes
May 22, 2024
Collaborator
isactornberg
left a comment
There was a problem hiding this comment.
As long as it's tested I trust it has the changes we need 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to separate out all of relox own modifications. It was possible to do for the nav2_controller package and
nav2_regulated_pure_pursuit_controller package. Also disabled the linter and auto formatter to not get a bunch of noop diff changes which are difficult to review.
But for the smac planner package we have here a mix of relox own modifications and changes coming from upstream when we once updated the package to get some upstream fixes to avoid costly areas better. That made it too difficult to separate things out so i just copied the entire folder from ros-2-main which also brought in a lot of linting and auto-formatting diffs, I don't think it's worth trying to undo the formatting. This PR branches out from the upstream
galacticbranch. When we move to humble, we need to try to rebase these changes on thehumblebranch, which will probably involve some manual labor and additional testing.Here are all of our PRs relating to modifications in nav2 that I could find in ros-2-main:
=== nav2_controller ===
=== nav2_smac_planner ===
=== nav2_regulated_pure_pursuit_controller ===
blame: https://github.com/relox-robotics/ros-2-main/blame/main/src/nav2_regulated_pure_pursuit_controller/src/regulated_pure_pursuit_controller.cpp#L364