Support Local Mappings Provider #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the concept of `providers` which works as a way to store and retrieve `QueryResponse` objects from a local environment instead of having to request it to the server. It also implements the first provider named `InMemoryMapProvider` which aims to provide an "offline" way to store existing `QueryResponse` objects in memory and use them to provide mappings. Then, whenever an object exists "offline" (in memory) it will be returned instead of having to request it from StArMap server. Refers to SPSTRAT-325
This commit changes the `StarmapClient` by adding a new constructor argument named `provider`, which when set with a `StArMapProvider` will use it to query image image first and only proceed to query the server whenever the mapping is not found in the local provider. Refers to SPSTRAT-325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of
providerswhich works as a way to store and retrieveQueryResponseobjects from a local environment instead of having to request it to the server.It also implements the first provider named
InMemoryMapProviderwhich aims to provide an "offline" way to store existingQueryResponseobjects in memory and use them to provide mappings. Then, whenever an object exists "offline" (in memory) it will be returned instead of having to request it from StArMap server.Finally, it changes the
StarmapClientby adding a new constructor argument namedprovider, which when set with aStArMapProviderwill use it to query image image first and only proceed to query the server whenever the mapping is not found in the local provider.Refers to SPSTRAT-325