Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

print the version once if there's an exact match to semantic version #33

Open
jasinner opened this issue Sep 13, 2018 · 7 comments
Open

Comments

@jasinner
Copy link
Collaborator

In the example output in the README there is this line:

github.com/opencontainers/image-spec@87998cd070d9e7a2c79f8b153a26bea0425582e5 =v1.0.0 ~v1.0.0

Why do we bother printing ~v1.0.0 does it have any meaning?

@jasinner
Copy link
Collaborator Author

Perhaps it's the =v1.0.0 part we should leave out? Or do you prefer it this way because it show's it not a generated semantic version tag?

@jasinner
Copy link
Collaborator Author

This is a nit-pick BTW.

@twaugh
Copy link
Collaborator

twaugh commented Sep 13, 2018

Yes, the pseudo-version field is not really needed if the exact-version field is available.

@jasinner
Copy link
Collaborator Author

Actually, it's more useful for our immediate needs if we print versions out like this:

github.com/opencontainers/image-spec:v1.0.0 (for exact match)

or

k8s.io/gengo:v0.0.0-0.20180529112933-461b8bcef4e1 (for generated version)

Do you think we could change the output format?

@twaugh
Copy link
Collaborator

twaugh commented Sep 17, 2018

So, [*]$PROJECT:$VERSION, same regardless of whether VERSION is an exact match or a pseudo-version? I think it's still useful to keep the asterisk marker to indicate the top-level project.

@jasinner
Copy link
Collaborator Author

jasinner commented Sep 17, 2018 via email

@twaugh
Copy link
Collaborator

twaugh commented Sep 25, 2018

Some users of this program will definitely still want to record the revision ID, even in the case of an exact tag match.

I was hoping we could make the format configurable using a template.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants