-
Notifications
You must be signed in to change notification settings - Fork 24
print the version once if there's an exact match to semantic version #33
Comments
Perhaps it's the =v1.0.0 part we should leave out? Or do you prefer it this way because it show's it not a generated semantic version tag? |
This is a nit-pick BTW. |
Yes, the pseudo-version field is not really needed if the exact-version field is available. |
Actually, it's more useful for our immediate needs if we print versions out like this: github.com/opencontainers/image-spec:v1.0.0 (for exact match) or k8s.io/gengo:v0.0.0-0.20180529112933-461b8bcef4e1 (for generated version) Do you think we could change the output format? |
So, |
Yes [ * ] $PROJECT:$VERSION
Agreed on keeping Asterix.
…On Mon, 17 Sep 2018 at 6:30 pm, Tim Waugh ***@***.***> wrote:
So, [*]$PROJECT:$VERSION, same regardless of whether VERSION is an exact
match or a pseudo-version? I think it's still useful to keep the asterisk
marker to indicate the top-level project.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6BdIlo_kl583iEFOwv6QTLSqFYd6yLks5ub12XgaJpZM4Wmxuj>
.
|
Some users of this program will definitely still want to record the revision ID, even in the case of an exact tag match. I was hoping we could make the format configurable using a template. |
In the example output in the README there is this line:
github.com/opencontainers/image-spec@87998cd070d9e7a2c79f8b153a26bea0425582e5 =v1.0.0 ~v1.0.0
Why do we bother printing ~v1.0.0 does it have any meaning?
The text was updated successfully, but these errors were encountered: