[RHELDST-2414] integration tests should log response headers #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebouillon
requested review from
crungehottman,
negillett and
rohanpm
as code owners
lmilbaum
suggested changes
Aug 11, 2020
tests/integration/test_exodus.py
Outdated
| @@ -9,6 +9,7 @@ def test_exodus_basic(cdn_test_url): | |||
| ) | |||
|
|
|||
| r = requests.get(url) | |||
| print(r.headers) | |||
There was a problem hiding this comment.
How about formatting the json in an easier way to read it.
https://www.journaldev.com/33302/python-pretty-print-json
There was a problem hiding this comment.
@lioramilbaum Yes! I will give it a try.
There was a problem hiding this comment.
@lioramilbaum done!
lmilbaum
previously approved these changes
Aug 11, 2020
|
@rohanpm @nathanegillett @crungehottman @lioramilbaum and the type of |
rohanpm
previously approved these changes
Aug 11, 2020
In exodus-lambda tests/integration, when a test fails because some attribute of a response doesn't match an expected value, the test output contains all headers on the response.
|
@rohanpm updated the commit message, please review. |
rohanpm
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In exodus-lambda tests/integration, when a test fails because some attribute of
a response doesn't match an expected value, the test output contains all headers
on the response.