Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into multiple packages #31

Open
mattecapu opened this issue Dec 27, 2016 · 2 comments
Open

Refactor into multiple packages #31

mattecapu opened this issue Dec 27, 2016 · 2 comments

Comments

@mattecapu
Copy link
Contributor

mattecapu commented Dec 27, 2016

Following #30, I think this module could provide just its core feature (support client-side middlewares for a Relay Network Layer) and then provide the built-ins middlewares as separated packages.
It would be relatively straightforward to implement, improve architecture and bundle size.

I can take care of this too @nodkz

@mattecapu mattecapu changed the title Refactor the module into multiple packages Refactor into multiple packages Dec 27, 2016
@nodkz
Copy link
Collaborator

nodkz commented Dec 29, 2016

I dislike an idea of many nano modules and polluting package.json. Almost all middlewares I'm using in my app.

But maybe core can be extracted to another package and all this middlewares keep here in one package.

Anyway I want to hear more thoughts...

@mattecapu
Copy link
Contributor Author

Personally, I use only urlMiddleware in production. It kind of bothers me having to use tree-shaking to exclude the other middlewares.
It's the same philosophy of express, browserify, babel, and so on. The size of the project is smaller, but I think that as Relay grows this could become a focal package.
Also it would help with issue tracking and semver. Much more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants