Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ejecting express-middleware to its own module #30

Open
mattecapu opened this issue Dec 27, 2016 · 2 comments
Open

Ejecting express-middleware to its own module #30

mattecapu opened this issue Dec 27, 2016 · 2 comments
Labels

Comments

@mattecapu
Copy link
Contributor

  1. It doesn't really belong to the network layer. It's just a mean to support the "batching protocol" that should be separated from the rest.
  2. Not everybody use express. I use koa and I made koa-graphql-batch to use this network layer, thus I don't need express-middleware.
  3. If one doesn't bother to do properly minification/tree-shaking, the middleware code will end up client side where it's all but needed.

I could take care of this if @nodkz agrees.

@nodkz
Copy link
Collaborator

nodkz commented Dec 29, 2016

@mattecapu 👍
I agree with you. Express-middleware should be extracted from RRNL. In the next month I'll start implementing subscriptions and bump new major version.

Before this moment let keep untouched this extra 1.6 kb of express-middleware for semver compatibility.

@nodkz nodkz added the 3.0.0 label Dec 29, 2016
@nodkz
Copy link
Collaborator

nodkz commented Dec 29, 2016

BTW. Please add a link to your koa-graphql-batch to readme. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants