Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ksg #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Ksg #7

wants to merge 6 commits into from

Conversation

dldldlfma
Copy link

Add comment env.py

env.py Outdated
@@ -87,6 +93,12 @@ def action_space(self):
return len(self.actions)

def render(self):
'''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' 대신 "사용해주세요

env.py Outdated
self.lives = 0 # Life counter (used in DeepMind training)
self.life_termination = False # Used to check if resetting only from loss of life
self.window = args.history_length # Number of frames to concatenate
self.state_buffer = deque([], maxlen=args.history_length)
self.state_buffer = deque([], maxlen=args.history_length) #make buffer
Copy link

@jcwleo jcwleo Aug 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# 하고 한칸 띄어주세요

env.py Outdated
self.lives = 0 # Life counter (used in DeepMind training)
self.life_termination = False # Used to check if resetting only from loss of life
self.window = args.history_length # Number of frames to concatenate
self.state_buffer = deque([], maxlen=args.history_length)
self.state_buffer = deque([], maxlen=args.history_length) #make buffer
self.training = True # Consistent with model training mode

def _get_state(self):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜 이함수를 사용하는지 docstring 적어주세요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants