Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 5, e2e tests, pre-commit hook, and GitHub workflow #26

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

HeavyMedl
Copy link
Collaborator

@HeavyMedl HeavyMedl commented May 23, 2024

  • Bumps dependencies for @rei/create-package
  • Upgrades Vite 5 and bumps associated dependencies for all initializer templates
  • Replaces import assertion with readFile/Parse JSON option to avoid warning and potential breakage in the future
  • Removes eslint and associated config and dependencies
  • Adds lint-staged to handle formatting staged files with prettier.
  • Adds pre-commit hook via husky to verify changes and execute lint-staged
  • Adds GitHub actions work-flow to build and test the initializer with changes
  • Adds end-to-end (e2e) tests that can be manually executed (npm run test:e2e) to ensure each template is properly scaffolded, installed, and built without error.

closes #25

@HeavyMedl HeavyMedl self-assigned this May 23, 2024
@HeavyMedl HeavyMedl marked this pull request as ready for review May 23, 2024 19:46
@HeavyMedl HeavyMedl changed the title Vite 5 Upgrades templates to use Vite 5 May 23, 2024
@@ -11,8 +11,8 @@
},
"license": "UNLICENSED",
"author": "REI",
"main": "dist/src/bin/main.mjs",
"bin": "dist/src/bin/main.mjs",
"main": "dist/bin/main.mjs",
Copy link
Collaborator Author

@HeavyMedl HeavyMedl May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the import assertion allows tsc to output to ./dist/ instead of ./dist/src/. See this thread:
https://stackoverflow.com/a/58941798

@HeavyMedl HeavyMedl changed the title Upgrades templates to use Vite 5 Vite 5, integration tests, pre-commit hook, and GitHub workflow May 24, 2024
@HeavyMedl HeavyMedl changed the title Vite 5, integration tests, pre-commit hook, and GitHub workflow Vite 5, e2e tests, pre-commit hook, and GitHub workflow May 25, 2024
src/bin/main.mts Outdated Show resolved Hide resolved
@HeavyMedl HeavyMedl requested a review from peripateticus May 28, 2024 16:11
@HeavyMedl HeavyMedl merged commit a1ae62d into main May 29, 2024
3 checks passed
@HeavyMedl HeavyMedl deleted the pr/vite-5 branch May 29, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create integration tests and trigger them on remote push events with GitHub Actions.
3 participants