Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial PR for expense updater helper #589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AhmedS343
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #589 into master will decrease coverage by 1.26%.
The diff coverage is 10.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   68.15%   66.88%   -1.27%     
==========================================
  Files          65       66       +1     
  Lines        6261     6402     +141     
==========================================
+ Hits         4267     4282      +15     
- Misses       1994     2120     +126     
Impacted Files Coverage Δ
regolith/helpers/u_expensehelper.py 10.00% <10.00%> (ø)
regolith/helper.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac680b0...907810f. Read the comment docs.

@sbillinge
Copy link
Contributor

Nice start, thanks @AhmedS343

I have played more with the todo updater. I wonder if it would be better if we use that as a template? I am not sure how much it deviates from the milestone updater, but it might be good synchronize them so they have the same behavior. @jiaweizang is working on the todo updater.

The first thing to work on is the tests that implement the use-cases before we code in any case. I suggest that you have a call with Jiawei and work together to harvest the UCs that she and i have developed for the todo updater, and adapt them, then write the tests. I can join that call too, since it has another purpose which is to discuss exactly the workflow that we want for just about all the updater helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants