Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to delete list of notifications by id #17

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

kgilmer
Copy link
Member

@kgilmer kgilmer commented Nov 13, 2021

I am working on a new front end that allows to bulk-delete notifications and am getting socket connect races when deleting each individually. Adding this command allows me to delete all with one socket connect.

Testing done

  • run notification w test data of notifications
  • connect to server via nc: nc -U /tmp/rofi_notification_daemon
  • send `delm:1,2,3' to server
  • observe output from dameon listing notifications deleted
  • send list to server, check that deleted ids are not returned

@cfsmp3
Copy link

cfsmp3 commented Nov 13, 2021

LGTM. The only concern I have, not specific about this PR but the daemon in general is that the sock file is hardcoded. Doesn't this cause conflicts with two simultaneous users?

@kgilmer
Copy link
Member Author

kgilmer commented Nov 14, 2021

LGTM. The only concern I have, not specific about this PR but the daemon in general is that the sock file is hardcoded. Doesn't this cause conflicts with two simultaneous users?

It would, I'm guessing. I don't know how common multi-user desktop computing is in 2021 but what would you suggest? It would need to be something discoverable by client programs...

@kgilmer kgilmer merged commit 7481617 into master Nov 14, 2021
@kgilmer kgilmer deleted the feat-multi-delete-by-id branch November 14, 2021 02:13
@cfsmp3
Copy link

cfsmp3 commented Nov 14, 2021

LGTM. The only concern I have, not specific about this PR but the daemon in general is that the sock file is hardcoded. Doesn't this cause conflicts with two simultaneous users?

It would, I'm guessing. I don't know how common multi-user desktop computing is in 2021 but what would you suggest? It would need to be something discoverable by client programs...

I'd say - just add the UID to the file name.

I'm guessing multi user is uncommon but probably non-zero :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants